Fix Incompatibility with JDK5 source level #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@OverRide is not allowed when implementing an interface method
kcooney
added a commit
that referenced
this pull request
Nov 8, 2014
Fix Incompatibility with JDK5 source level
|
Thanks! I sent the same fix :-/ |
|
@marcphilipp I am sorry for that, I didn't know junit was still using jdk5. I will take care of that in future. |
|
@NarendraPathai No problem! Unfortunately, Travis does not support JDK 5 so such issues don't get caught automatically before merging the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced by #1015 and only discovered now because CloudBees broke our Jenkins build by updating Jenkins which apparently no longer supports Maven builds running on JDK5... 😱